Problems with pull request #2536

Programmers discuss here anything related to FreeOrion programming. Primarily for the developers to discuss.

Moderators: Committer, Committer

Post Reply
Message
Author
spikethehobbit
Space Squid
Posts: 62
Joined: Mon Aug 27, 2012 7:24 pm

Problems with pull request #2536

#1 Post by spikethehobbit » Thu Oct 31, 2019 11:09 am

Since pull request #2536 was merged, the server unconditionally listens on a UDPv6 port for discovery requests. This causes two problems:

First, single player games should not be listening for server discovery since they should not be accepting LAN connections.

Second, requiring IPv6 breaks single player on IPv4-only machines because the server crashes on startup.

Code: Select all

terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::system::system_error> >'
  what():  open: Address family not supported by protocol
Aborted
The problem commit is 6e933988d858e7ccf5832db72ac0afcd63bc1f9f
All contributions are submitted under GPL or LGPL v2 or later, or under appropriate Creative Commons licence, consistent with project guidlines.

User avatar
Vezzra
Release Manager, Design
Posts: 5038
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: Problems with pull request #2536

#2 Post by Vezzra » Fri Nov 01, 2019 12:07 pm

I have opened a corresponding issue on github: #2626

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12474
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Problems with pull request #2536

#3 Post by Geoff the Medio » Sat Nov 02, 2019 11:26 am

spikethehobbit wrote:
Thu Oct 31, 2019 11:09 am
First, single player games should not be listening for server discovery since they should not be accepting LAN connections.
Why is this a problem? The point is to enable interprocess communication, to query the server, whether that's on the same system or otherwise.

User avatar
Vezzra
Release Manager, Design
Posts: 5038
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: Problems with pull request #2536

#4 Post by Vezzra » Thu Nov 07, 2019 12:22 pm

The server crashing on IP4-only machines is a quite serious issue though. That definitely needs to be fixed for 0.4.9.

o01eg
Programmer
Posts: 544
Joined: Sat Dec 10, 2011 5:46 am

Re: Problems with pull request #2536

#5 Post by o01eg » Mon Nov 11, 2019 9:33 pm

spikethehobbit wrote:
Thu Oct 31, 2019 11:09 am
Since pull request #2536 was merged, the server unconditionally listens on a UDPv6 port for discovery requests. This causes two problems:

First, single player games should not be listening for server discovery since they should not be accepting LAN connections.

Second, requiring IPv6 breaks single player on IPv4-only machines because the server crashes on startup.

Code: Select all

terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::system::system_error> >'
  what():  open: Address family not supported by protocol
Aborted
The problem commit is 6e933988d858e7ccf5832db72ac0afcd63bc1f9f
Could you test if this PR fixed your issue? https://github.com/freeorion/freeorion/pull/2640
Gentoo Linux x64, gcc-9.2, boost-1.71.0
Ubuntu Server 18.04 x64, gcc-7.4, boost-1.65.1
Welcome to slow multiplayer game at freeorion-lt.dedyn.io. Version 2019-11-17.58f0b8e.
Donates are welcome: BTC:14XLekD9ifwqLtZX4iteepvbLQNYVG87zK

o01eg
Programmer
Posts: 544
Joined: Sat Dec 10, 2011 5:46 am

Re: Problems with pull request #2536

#6 Post by o01eg » Thu Nov 14, 2019 7:21 pm

I've updated my PR. Could you test if it solved your issue?
Gentoo Linux x64, gcc-9.2, boost-1.71.0
Ubuntu Server 18.04 x64, gcc-7.4, boost-1.65.1
Welcome to slow multiplayer game at freeorion-lt.dedyn.io. Version 2019-11-17.58f0b8e.
Donates are welcome: BTC:14XLekD9ifwqLtZX4iteepvbLQNYVG87zK

User avatar
Vezzra
Release Manager, Design
Posts: 5038
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: Problems with pull request #2536

#7 Post by Vezzra » Sun Nov 17, 2019 11:44 am

@spikethehobbit, your input for o01eg's fix would be much appreciated... the issue is release-blocking after all, and therefore somewhat urgent...

Post Reply