Problems with pull request #2536

[spikethehobbit]

Since pull request #2536 was merged, the server unconditionally listens on a UDPv6 port for discovery requests. This causes two problems:

First, single player games should not be listening for server discovery since they should not be accepting LAN connections.

Second, requiring IPv6 breaks single player on IPv4-only machines because the server crashes on startup.

Code: Select all

terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::system::system_error> >'
  what():  open: Address family not supported by protocol
Aborted

The problem commit is 6e933988d858e7ccf5832db72ac0afcd63bc1f9f

[Vezzra]

I have opened a corresponding issue on github: #2626

[Geoff the Medio]

First, single player games should not be listening for server discovery since they should not be accepting LAN connections.

Why is this a problem? The point is to enable interprocess communication, to query the server, whether that's on the same system or otherwise.

[Vezzra]

The server crashing on IP4-only machines is a quite serious issue though. That definitely needs to be fixed for 0.4.9.

[o01eg]

Since pull request #2536 was merged, the server unconditionally listens on a UDPv6 port for discovery requests. This causes two problems:

First, single player games should not be listening for server discovery since they should not be accepting LAN connections.

Second, requiring IPv6 breaks single player on IPv4-only machines because the server crashes on startup.

Code: Select all

terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::system::system_error> >'
  what():  open: Address family not supported by protocol
Aborted

The problem commit is 6e933988d858e7ccf5832db72ac0afcd63bc1f9f

Could you test if this PR fixed your issue? https://github.com/freeorion/freeorion/pull/2640

[o01eg]

I've updated my PR. Could you test if it solved your issue?

[Vezzra]

@spikethehobbit, your input for o01eg's fix would be much appreciated... the issue is release-blocking after all, and therefore somewhat urgent...

[spikethehobbit]

I apologize for the delay. Just tested it and it works correctly for both single and multiplayer games. Thank you.

[Vezzra]

Perfect