local build broken

Questions, problems and discussion about compiling FreeOrion.

Moderator: Oberlus

Post Reply
Message
Author
Ophiuchus
Programmer
Posts: 3498
Joined: Tue Sep 30, 2014 10:01 am
Location: Wall IV

local build broken

#1 Post by Ophiuchus »

not sure what caused it but i cant build the latest master locally

Code: Select all

/home/ophiuchus/freeorion/Empire/Empire.cpp:1304:75:   required from here
/usr/include/boost/move/detail/iterator_traits.hpp:48:49: error: no type named 'pointer' in 'struct std::ranges::elements_view<std::ranges::ref_view<const std::map<int, int> >, 0>::_Iterator<true>'
   48 |    typedef typename Iterator::pointer           pointer;
      |                                                 ^~~~~~~
/usr/include/boost/move/detail/iterator_traits.hpp:49:49: error: no type named 'reference' in 'struct std::ranges::elements_view<std::ranges::ref_view<const std::map<int, int> >, 0>::_Iterator<true>'
   49 |    typedef typename Iterator::reference         reference;
      |                                                 ^~~~~~~~~
any hints?
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

Look, ma... four combat bouts!

Ophiuchus
Programmer
Posts: 3498
Joined: Tue Sep 30, 2014 10:01 am
Location: Wall IV

Re: local build broken

#2 Post by Ophiuchus »

note: boost 1.78, fedora 37

(and it seems 1.78 is also the fedora 38 version; 1.81 is coming to fedora 39 but that should be finished in 2023-10-24)
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

Look, ma... four combat bouts!

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13615
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: local build broken

#3 Post by Geoff the Medio »


Ophiuchus
Programmer
Posts: 3498
Joined: Tue Sep 30, 2014 10:01 am
Location: Wall IV

Re: local build broken

#4 Post by Ophiuchus »

Geoff the Medio wrote: Tue Aug 29, 2023 11:06 pm try with https://github.com/freeorion/freeorion/pull/4720
error does not go away with that change; started to bisect
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

Look, ma... four combat bouts!

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13615
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: local build broken

#5 Post by Geoff the Medio »

Really? I set up a test on Compiler Explorer that seemed to confirm that 1.79 as the cutoff would work. You can change the used Boost version by clicking the Libraries button at the right top.

Ophiuchus
Programmer
Posts: 3498
Joined: Tue Sep 30, 2014 10:01 am
Location: Wall IV

Re: local build broken

#6 Post by Ophiuchus »

Culprit commit is 9ba67a5d8afc69fffe08f869568374964b96fcfb as you expected I guess
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

Look, ma... four combat bouts!

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13615
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: local build broken

#7 Post by Geoff the Medio »

What commit introduced the problem isn't interesting. What Boost version test fixes it is. Apparently your system reacts differently to the same Boost version as Compile Explorer...?

Ophiuchus
Programmer
Posts: 3498
Joined: Tue Sep 30, 2014 10:01 am
Location: Wall IV

Re: local build broken

#8 Post by Ophiuchus »

Geoff the Medio wrote: Wed Aug 30, 2023 8:54 pm What commit introduced the problem isn't interesting. What Boost version test fixes it is.
yes. but there was another boost check introduced in that commit in Supply.cpp and also upping that to boost version > 107800 finally worked
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

Look, ma... four combat bouts!

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13615
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: local build broken

#9 Post by Geoff the Medio »

I suggest you comment on https://github.com/freeorion/freeorion/pull/4720 and suggest the necessary changes, or otherwise make a pull request that fixes it.

Ophiuchus
Programmer
Posts: 3498
Joined: Tue Sep 30, 2014 10:01 am
Location: Wall IV

Re: local build broken

#10 Post by Ophiuchus »

Geoff the Medio wrote: Thu Aug 31, 2023 8:48 am I suggest you comment on https://github.com/freeorion/freeorion/pull/4720 and suggest the necessary changes, or otherwise make a pull request that fixes it.
ok, finally my system is compiling master successfully again; PR-4722

thank you for the fix :mrgreen:
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

Look, ma... four combat bouts!

Post Reply