Page 1 of 1
Patches for Summary pull request
Posted: Mon Jul 13, 2015 11:50 am
by Geoff the Medio
dunno how better to suggest changes to a change...
Re: Patches for Summary pull request
Posted: Mon Jul 13, 2015 1:42 pm
by vincele
There's also the possibility of using a github PR against my branch, but that'll do fine, I'll get those folded in.
Thanks.
Re: Patches for Summary pull request
Posted: Mon Jul 13, 2015 2:06 pm
by vincele
BTW, why is that post titled "Patches for Summary pull request" ?
Re: Patches for Summary pull request
Posted: Mon Jul 13, 2015 2:26 pm
by Geoff the Medio
Because they were patches for the pull request about "Suitability" and I mixed it up with my own pull request with the slightly similar looking word "Summary".
Re: Patches for Summary pull request
Posted: Mon Jul 13, 2015 3:50 pm
by vincele
OK, I thought it was just that but still wanted to be sure...
Could you have a look at :
https://github.com/vincele/freeorion/co ... uitability
I folded your grooming & MSVC into the series.
I also added an additional patch to get the cheapest colony building
returned by getbestsuitable, because exobots would have been
chosen before that when they actually cost more to produce...
Please tell how you want that series split in PRs, or if I goofed something...