Patches for Summary pull request

Programmers discuss here anything related to FreeOrion programming. Primarily for the developers to discuss.

Moderator: Committer

Post Reply
Message
Author
User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12771
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Patches for Summary pull request

#1 Post by Geoff the Medio »

dunno how better to suggest changes to a change...
Attachments

[The extension patch has been deactivated and can no longer be displayed.]

[The extension patch has been deactivated and can no longer be displayed.]


User avatar
vincele
Space Dragon
Posts: 341
Joined: Sun Mar 23, 2014 6:10 pm

Re: Patches for Summary pull request

#2 Post by vincele »

There's also the possibility of using a github PR against my branch, but that'll do fine, I'll get those folded in.
Thanks.
All the patches I'll provide for freeorion will be released under the GPL v2 or later license.
Let's unleash the dyson forest powa!

User avatar
vincele
Space Dragon
Posts: 341
Joined: Sun Mar 23, 2014 6:10 pm

Re: Patches for Summary pull request

#3 Post by vincele »

BTW, why is that post titled "Patches for Summary pull request" ?
All the patches I'll provide for freeorion will be released under the GPL v2 or later license.
Let's unleash the dyson forest powa!

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12771
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Patches for Summary pull request

#4 Post by Geoff the Medio »

Because they were patches for the pull request about "Suitability" and I mixed it up with my own pull request with the slightly similar looking word "Summary".

User avatar
vincele
Space Dragon
Posts: 341
Joined: Sun Mar 23, 2014 6:10 pm

Re: Patches for Summary pull request

#5 Post by vincele »

OK, I thought it was just that but still wanted to be sure...

Could you have a look at :
https://github.com/vincele/freeorion/co ... uitability

I folded your grooming & MSVC into the series.

I also added an additional patch to get the cheapest colony building
returned by getbestsuitable, because exobots would have been
chosen before that when they actually cost more to produce...

Please tell how you want that series split in PRs, or if I goofed something...
All the patches I'll provide for freeorion will be released under the GPL v2 or later license.
Let's unleash the dyson forest powa!

Post Reply