CombatReport warnings

Programmers discuss here anything related to FreeOrion programming. Primarily for the developers to discuss.

Moderator: Committer

Post Reply
Message
Author
User avatar
vincele
Space Dragon
Posts: 341
Joined: Sun Mar 23, 2014 6:10 pm

CombatReport warnings

#1 Post by vincele »

Hello,

the latest code made clang emit new warnings :

Code: Select all

In file included from /home/vince/repo/upstream/FreeOrion-llvm/UI/CombatReport/CombatReportData.cpp:2:
/home/vince/repo/upstream/FreeOrion-llvm/UI/CombatReport/../../combat/CombatEvents.h:31:1: warning: 'AttackEvent' defined as a struct here but previously declared as a class [-Wmismatched-tags]
struct AttackEvent : public CombatEvent {
^
/home/vince/repo/upstream/FreeOrion-llvm/UI/CombatReport/CombatReportData.h:10:1: note: did you mean struct here?
class AttackEvent;
^~~~~
struct
In file included from /home/vince/repo/upstream/FreeOrion-llvm/UI/CombatReport/CombatReportData.cpp:3:
/home/vince/repo/upstream/FreeOrion-llvm/UI/CombatReport/../../combat/CombatLogManager.h:11:1: warning: 'CombatParticipantState' defined as a struct here but previously declared as a class [-Wmismatched-tags]
struct CombatParticipantState {
^
/home/vince/repo/upstream/FreeOrion-llvm/UI/CombatReport/CombatReportData.h:11:1: note: did you mean struct here?
class CombatParticipantState;
^~~~~
struct
2 warnings generated.
This patch fixes them for me, but they may be sufficiently harmless, your call...

[The extension diff has been deactivated and can no longer be displayed.]

All the patches I'll provide for freeorion will be released under the GPL v2 or later license.
Let's unleash the dyson forest powa!

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13587
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: CombatReport warnings

#2 Post by Geoff the Medio »

Looks fine, committed.

Post Reply