[patch] Fix segfault on exit

Programmers discuss here anything related to FreeOrion programming. Primarily for the developers to discuss.

Moderator: Committer

Post Reply
Message
Author
Mitten.O
Programmer
Posts: 255
Joined: Sun Apr 06, 2014 4:15 pm

[patch] Fix segfault on exit

#1 Post by Mitten.O »

ObjectListBox uses a custom Row object for a header row and maintains a pointer to it. It was deleting it trough the pointer despite giving it to ListBox, which deletes it also, resulting in a segfault on deconstruction.
Attachments

[The extension patch has been deactivated and can no longer be displayed.]

Any code by me in this post is released under GPL 2.0 or later.

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13587
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: [patch] Fix segfault on exit

#2 Post by Geoff the Medio »

Applies and builds OK for me.

User avatar
Dilvish
AI Lead and Programmer Emeritus
Posts: 4768
Joined: Sat Sep 22, 2012 6:25 pm

Re: [patch] Fix segfault on exit

#3 Post by Dilvish »

works for me too. Nice catch.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

User avatar
Dilvish
AI Lead and Programmer Emeritus
Posts: 4768
Joined: Sat Sep 22, 2012 6:25 pm

Re: [patch] Fix segfault on exit

#4 Post by Dilvish »

Code: Select all

r7780 | dilvish-fo | 2014-11-30 17:22:25 -0800 (Sun, 30 Nov 2014) | 1 line
patch by Mitten.O fixing a pointer error that led to SegFault upon game close
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

Post Reply