I saw what I think is useless code (maybe a leftover from the past) in
SidePanel::PlanetPanel::PlanetPanel() ctor. I think m_planet_graphic
is always NULL there, since it is only allocated in RefreshPlanetGraphic(),
which BTW could probably use gards against freeing the initial NULL pointers.
Leftover code ?
Moderator: Committer
Leftover code ?
All the patches I'll provide for freeorion will be released under the GPL v2 or later license.
Let's unleash the dyson forest powa!
Let's unleash the dyson forest powa!
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13587
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: Leftover code ?
Please post patches with file pathes relative to the FreeOrion directory, not with FreeOrion/ at the start. This one is small enough I can remove it by hand, though.
Seems harmless enough... https://sourceforge.net/p/freeorion/code/7715/
Seems harmless enough... https://sourceforge.net/p/freeorion/code/7715/
Re: Leftover code ?
Don't your patch utility have a "-pnum or --strip=num" command-line option ?Geoff the Medio wrote:Please post patches with file pathes relative to the FreeOrion directory, not with FreeOrion/ at the start. This one is small enough I can remove it by hand, though.
I ask, because if I cannot find a way to hardcode the creation of patches with the right -p level into quilt config files, there's some good chance that I'll forget everytime as I don't create the patches by hand... :-/ Sometimes with "svn diff", and the rest with "quilt new"...
I can only promise to try to remember though...
All the patches I'll provide for freeorion will be released under the GPL v2 or later license.
Let's unleash the dyson forest powa!
Let's unleash the dyson forest powa!
Re: Leftover code ?
No, he's using TortoiseSVN and it has no such option.vincele wrote:Don't your patch utility have a "-pnum or --strip=num" command-line option ?
It should be easy for you with svn diff -- just cd one more directory level in before you do svn diff.I ask, because if I cannot find a way to hardcode the creation of patches with the right -p level... Sometimes with "svn diff"
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0
Re: Leftover code ?
Ouch, but there's still cygwin... [I'm out, jumped through the window]Dilvish wrote:No, he's using TortoiseSVN and it has no such option.vincele wrote:Don't your patch utility have a "-pnum or --strip=num" command-line option ?
The problem's not how to do it, I know that, but the remembering, and that borders on NP-completeness...Dilvish wrote:It should be easy for you with svn diff -- just cd one more directory level in before you do svn diff.I ask, because if I cannot find a way to hardcode the creation of patches with the right -p level... Sometimes with "svn diff"
All the patches I'll provide for freeorion will be released under the GPL v2 or later license.
Let's unleash the dyson forest powa!
Let's unleash the dyson forest powa!
Re: Leftover code ?
I suggest you try what I do, which is to totally bypass that extra "FreeOrion" directory altogether:vincele wrote:The problem's not how to do it, I know that, but the remembering, and that borders on NP-completeness...
instead of something of the form
Code: Select all
svn co https://svn.code.sf.net/p/freeorion/code/trunk freeorion
Code: Select all
svn co https://svn.code.sf.net/p/freeorion/code/trunk/FreeOrion freeorion
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0