Why are the Python modules using print instead of logging.info /.debug /.warning?
It's fairly easy to switch the logging output between stderr, with no special formatting, and outputting to the freeoriond.log with timestamps and everything.
Release builds could then include feedback from the python code inside the appropriate logs by default, which seems more conveninent than going through the command line route as of now.
Can we haz logging? I can put together a patch to that effect fairly quickly, if that's acceptable.
And a c++ question: in the past I found myself changing
Code: Select all
if (this_condition)
DoThis();
Code: Select all
if (this_condition)
DoThis();
DoThat();
Having
Code: Select all
if (this_condition) {
DoThis();
}
As a consequence, I've got into the habit of always bracketing all ifs to avoid that particular pitfall.
However, I noticed that in recent commits a few if statements have been de-bracketed, to coin a phrase.
What's the official FO if bracketing policy?