DynamicGraphic scaling => flicker

[vincele]

Hello, I'm trying to do something like suggested in Feature Request 126, i.e. scaling down uncolonized planet's panels.

Looks good for rotating planet, but I'm having problems with asteroid's DynamicGraphic scaling.

In UI/SidePanel.cpp:1026 :

Code: Select all

SidePanel::PlanetPanel::RefreshPlanetGraphic()

I change planet_image_pos.x and scale texture_width, which get me the right placement and size, but the resulting animation flickers a lot.

I tried changing m_planet_graphic->SetFPS(), it got slightly better by upping the FPS but cannot completely eliminate the flickering.

Any advice ?

[Dilvish]

you can certainly have a bit of commiseration regarding our asteroid graphics, and a bit of advice that may or may not pan out as a helpful lead.

I recall that after one or two marginally related changes in the past the asteroid graphics on Linux had gotten thrown off, being either frozen or very jumpy (could easily be characterized as flickering). I'm a bit fuzzy now on the actual code change that triggered the problem, but I seem to recall the connection wasn't readily apparent. It turned out that that the change exposed an implementation difference between windows and linux (for some file handling software I think it was) that was causing the individual asteroid frames to get returned in a different order, which gave a bad result on Linux. That was fixed in r6163 by doing an additional sort on the filenames.

That's kind of a long-winded way of getting to the main point: could your dynamic resizing be throwing off the sorting of the frames?

[vincele]

you can certainly have a bit of commiseration regarding our asteroid graphics, and a bit of advice that may or may not pan out as a helpful lead.

In fact, yes, I'm pulling some of my hair...

That's kind of a long-winded way of getting to the main point: could your dynamic resizing be throwing off the sorting of the frames?

I don't think so, but will try to look for that. First I have to get the scaling right, and that means pulling some GG-coordinate-system hairs...

[Geoff the Medio]

In GetAsteroidTextures() the call to GetPrefixedTextures(...) specifies false for the mipmapping parameter. Might help to turn it on if you're planning to resize the textures when displaying.

[vincele]

In GetAsteroidTextures() the call to GetPrefixedTextures(...) specifies false for the mipmapping parameter. Might help to turn it on if you're planning to resize the textures when displaying.

Thanks, I'll try that.

EDIT: tried, does not fix it...

That's what I'm doing (kind of) :

Code: Select all

        m_planet_graphic = new GG::DynamicGraphic(planet_image_pos.x, planet_image_pos.y,
                                                    texture_width / 2, texture_height, true,
                                                    texture_width / 2, texture_height, 0, textures,
                                                    GG::GRAPHIC_SHRINKFIT | GG::GRAPHIC_PROPSCALE);

[vincele]

Ougl, removing GG::GRAPHIC_PROPSCALE does fix it, but now it looks ugly...

Maybe by scaling it proportionally myself with proper width & height...