[Patch] Determine lines only on genuine resize

Programmers discuss here anything related to FreeOrion programming. Primarily for the developers to discuss.

Moderator: Committer

Post Reply
Message
Author
Mitten.O
Programmer
Posts: 255
Joined: Sun Apr 06, 2014 4:15 pm

[Patch] Determine lines only on genuine resize

#1 Post by Mitten.O »

While on my research window speed up quest,
I noticed that TextControl::SizeMove calls DetermineLines
also when only the position, not the size of the control is changed.

Fixing this gives a significant speedup at least for me, now that the labels are implemented with
ShadowedTextControls.
Attachments

[The extension patch has been deactivated and can no longer be displayed.]

Any code by me in this post is released under GPL 2.0 or later.

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13587
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: [Patch] Determine lines only on genuine resize

#2 Post by Geoff the Medio »

Looks reasonable. Committed.

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13587
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: [Patch] Determine lines only on genuine resize

#3 Post by Geoff the Medio »

Not sure if it's related, but I don't recall seeing this before... When scrolling through the messages window, text colour is intermittently glitchy depending on the text position. Possibly the parsing of tags is being messed up somehow?
Attachments
text colour quirks
text colour quirks
text_colour_quirks.png (66.97 KiB) Viewed 1131 times

User avatar
Foocaux
Space Squid
Posts: 78
Joined: Sat Jul 26, 2014 7:14 am

Re: [Patch] Determine lines only on genuine resize

#4 Post by Foocaux »

I think I saw that with 7311, before I started rolling my own builds.
The small print: Any code contribution I make to FreeOrion is made under GPL v2.0, any graphic contribution is under CC-by-SA 3.0

User avatar
Cjkjvfnby
AI Contributor
Posts: 539
Joined: Tue Jun 24, 2014 9:55 pm

Re: [Patch] Determine lines only on genuine resize

#5 Post by Cjkjvfnby »

Foocaux wrote:I think I saw that with 7311, before I started rolling my own builds.
It was present before r7229.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

User avatar
MatGB
Creative Contributor
Posts: 3310
Joined: Fri Jun 28, 2013 11:45 pm

Re: [Patch] Determine lines only on genuine resize

#6 Post by MatGB »

I have memories of it happening plenty of times in the past, but we now have more frequent colours due to the reporting of aggressive state, I remember it used to happen back when I'd try to force peace with AIs and similar. No idea what's causing it, but it's not new.
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

Post Reply