EncyclopediaDetailPanel question

[Geoff the Medio]

Is there a reason to add a separate constructor taking a parameter for the flags, rather than adding a parameter and using a default value equal to the old flags? Would avoid needed to add Init() as well...

[vincele]

Because my C++ is *very* rusty... Here's a new one...

[The extension diff has been deactivated and can no longer be displayed.]

[vincele]

I also would like to propose another change to EDP, mainly removing the "static" from m_items & m_items_it, because I see no reason that one EDP change another one's state.
I prefer them to stay away from each other's toes, so that when closing design, prod or research window, the mapwnd's pedia is still on the page it was before toggling those full screen windows.

[The extension diff has been deactivated and can no longer be displayed.]

[Geoff the Medio]

Here's a new one...

You don't specify default parameters in the constructor declaration.

[vincele]

You mean the .h does not need any modification ?

[Geoff the Medio]

"don't" meant "didn't"

Your constructor declaration doesn't specify default parameters. The constructor is used elsewhere assuming 2 parameters, but needs 3, because there is no default for the new parameter.

[vincele]

like this ?

[The extension diff has been deactivated and can no longer be displayed.]

If not, I clearly don't understand what you're speaking about, sorry...

[adrian_broher]

If not, I clearly don't understand what you're speaking about, sorry...

To specify default parameters the declaration needs to define the default parameters

TheClass.h

Code: Select all

#ifndef THECLASS_H
#define THECLASS_H
class TheClass {
public:
    TheClass(int param1, int param2 = 2); // param2 has now the default value 2
};
#endif

TheClass.cpp

Code: Select all

#include "TheClass.h"

TheClass::TheClass(int param1, int param2) // the definition doesn't contain the default parameter
{
}

TheClient.cpp

Code: Select all

#include "TheClass.h"

int main(int argc, char** argv)
{
    TheClass intstance1(5); // a instance with param2 = 2 is created;
    TheClass instance2(5, 3); // this instance has param2 with the value 3;
}

[Geoff the Medio]

That patch builds and runs, and hides the X on the design screen, but it didn't deal with the research and production screens with the same issue...

[vincele]

That patch builds and runs, and hides the X on the design screen, but it didn't deal with the research and production screens with the same issue...

I know the code for prod & research didn't have anything but I don't see the X button on those EDPs so I didn't fix the non-problem, I did the minimal fix... Do you see an X button on those ? As I'm not seeing any close buttons on those I won't be able to test the additional changes...

Here is the updated patch...

[The extension diff has been deactivated and can no longer be displayed.]

Thanks Adrian for the perfect explanations.

[Geoff the Medio]

Try dragging the research and production pedia panels around. For some reason the X doesn't appear until they're moved for me...

[vincele]

Try dragging the research and production pedia panels around. For some reason the X doesn't appear until they're moved for me...

Indeed, the button appeared after wnd move, and the latest patch fixes that.

Any thoughts about the static-ectomy patch ?

[Geoff the Medio]

Committed the button patch... https://sourceforge.net/p/freeorion/code/7303/

[vincele]

Thanks a lot for the mentoring.

Let me know what you think about the idea of removing the static, there's no rush though.