Patch: Use cmake FindThreads module in GG

Message

adrian_broher · #1 Post by **adrian_broher** » Wed Mar 20, 2013 8:02 am

Hello fo-devs,

the attached patch removes the custom written platform specific link flags selection for threads and replaces it with a cmake find_package call utilizing the FindThreads cmake module.

#2 Post by **Geoff the Medio** » Wed Mar 20, 2013 8:06 am

I'll need feedback from people who regularly compile on Linux or OSX to address this...

#3 Post by **Vezzra** » Wed Mar 20, 2013 9:27 am

I don't use cmake to build FO on OSX, so I can't help you with that, sorry...

#4 Post by **Dilvish** » Thu Mar 21, 2013 7:03 am

This worked fine for me on Ubuntu Linux

adrian_broher · #5 Post by **adrian_broher** » Sat Mar 30, 2013 10:12 pm

The attached patch fixes the initial population of the cmake cache. The previous version didn't set the BUILD_MULTI_THREADED option early enough to add the pthread library to the linker options for the initial cmake cache population.

#6 Post by **Geoff the Medio** » Sat Mar 30, 2013 10:16 pm

Is that a replacement for the previous patch?

adrian_broher · #7 Post by **adrian_broher** » Sat Mar 30, 2013 10:20 pm

Geoff the Medio wrote:Is that a replacement for the previous patch?

No, it's an additional patch. Should I have created a new thread for that?

#8 Post by **Geoff the Medio** » Sat Mar 30, 2013 10:47 pm

Should I have created a new thread for that?

No, it's fine. I just wanted to clarify.

FreeOrion

Patch: Use cmake FindThreads module in GG

Patch: Use cmake FindThreads module in GG

Re: Patch: Use cmake FindThreads module in GG

Re: Patch: Use cmake FindThreads module in GG

Re: Patch: Use cmake FindThreads module in GG

Re: Patch: Use cmake FindThreads module in GG

Re: Patch: Use cmake FindThreads module in GG

Re: Patch: Use cmake FindThreads module in GG

Re: Patch: Use cmake FindThreads module in GG