Listing artistic species in Pedia

Programmers discuss here anything related to FreeOrion programming. Primarily for the developers to discuss.

Moderator: Committer

Message
Author
wobbly
Cosmic Dragon
Posts: 1873
Joined: Thu Oct 10, 2013 6:48 pm

Re: Listing artistic species in Pedia

#16 Post by wobbly »

Geoff the Medio wrote: Wed Feb 16, 2022 7:46 pm Did you add something else to get the artistic species article to have the list and working icon? I just get the article text and an error on the command line about the artisans icon being missing, since it's been renamed to social_artisans.png
I tested with these changes in:

https://github.com/freeorion/freeorion/ ... 75f9fb9de9

and PEDIA_ARTISTIC added to the tags of the .focs of all artistic species

and this change in stringtables

Code: Select all

ARTISTIC_SPECIES_TRAIT_TEXT
'''
Artistic species produce artistic works when their empire has adopted [[policy PLC_ARTISAN_WORKSHOPS]], which generates influence. Additionally, other planets with different artistic species in the same system are more stable.

List of Artistic species:
'''

User avatar
stpa
Space Kraken
Posts: 157
Joined: Mon Mar 12, 2018 1:08 pm

Re: Listing artistic species in Pedia

#17 Post by stpa »

wobbly wrote: Wed Feb 16, 2022 7:57 pm and PEDIA_ARTISTIC added to the tags of the .focs of all artistic species
wait a second, we have a second tag then? why not reuse the preexisting ARTISTIC tag? other than that, +1

wobbly
Cosmic Dragon
Posts: 1873
Joined: Thu Oct 10, 2013 6:48 pm

Re: Listing artistic species in Pedia

#18 Post by wobbly »

stpa wrote: Thu Feb 17, 2022 8:16 am
wobbly wrote: Wed Feb 16, 2022 7:57 pm and PEDIA_ARTISTIC added to the tags of the .focs of all artistic species
wait a second, we have a second tag then? why not reuse the preexisting ARTISTIC tag? other than that, +1
Not sure the reason for that setup but it was always 2 tags:

tags = [ "LITHIC" "BAD_RESEARCH" "GOOD_INFLUENCE" "GOOD_HAPPINESS" "AVERAGE_SUPPLY" "PEDIA_LITHIC_SPECIES_CLASS" ]

LITHIC and PEDIA_LITHIC for instance

Edit: You'd probably get some interesting results if you don't use Pedia_ tags. There's all sorts of stuff from the stringtables that you'd just pick up by accident.

Ophiuchus
Programmer
Posts: 3433
Joined: Tue Sep 30, 2014 10:01 am
Location: Wall IV

Re: Listing artistic species in Pedia

#19 Post by Ophiuchus »

wobbly wrote: Thu Feb 17, 2022 8:26 am
stpa wrote: Thu Feb 17, 2022 8:16 am wait a second, we have a second tag then? why not reuse the preexisting ARTISTIC tag? other than that, +1
Edit: You'd probably get some interesting results if you don't use Pedia_ tags. There's all sorts of stuff from the stringtables that you'd just pick up by accident.
yeah, its specific for telling that there should be certain pedia content shown.
and the other way round (using PEDIA_LITHIC to indicate lithic species) is probably too strange.

also there might be some cases where you want an effect, but not the pedia content.
like having a building which interacts with lithics and so you want to show it with PEDIA_LITHIC, but none of the LITHIC effects should apply.
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

Look, ma... four combat bouts!

Post Reply