Page 1 of 1

Problems with pull request #2536

Posted: Thu Oct 31, 2019 11:09 am
by spikethehobbit
Since pull request #2536 was merged, the server unconditionally listens on a UDPv6 port for discovery requests. This causes two problems:

First, single player games should not be listening for server discovery since they should not be accepting LAN connections.

Second, requiring IPv6 breaks single player on IPv4-only machines because the server crashes on startup.

Code: Select all

terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::system::system_error> >'
  what():  open: Address family not supported by protocol
Aborted
The problem commit is 6e933988d858e7ccf5832db72ac0afcd63bc1f9f

Re: Problems with pull request #2536

Posted: Fri Nov 01, 2019 12:07 pm
by Vezzra
I have opened a corresponding issue on github: #2626

Re: Problems with pull request #2536

Posted: Sat Nov 02, 2019 11:26 am
by Geoff the Medio
spikethehobbit wrote:
Thu Oct 31, 2019 11:09 am
First, single player games should not be listening for server discovery since they should not be accepting LAN connections.
Why is this a problem? The point is to enable interprocess communication, to query the server, whether that's on the same system or otherwise.

Re: Problems with pull request #2536

Posted: Thu Nov 07, 2019 12:22 pm
by Vezzra
The server crashing on IP4-only machines is a quite serious issue though. That definitely needs to be fixed for 0.4.9.

Re: Problems with pull request #2536

Posted: Mon Nov 11, 2019 9:33 pm
by o01eg
spikethehobbit wrote:
Thu Oct 31, 2019 11:09 am
Since pull request #2536 was merged, the server unconditionally listens on a UDPv6 port for discovery requests. This causes two problems:

First, single player games should not be listening for server discovery since they should not be accepting LAN connections.

Second, requiring IPv6 breaks single player on IPv4-only machines because the server crashes on startup.

Code: Select all

terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::system::system_error> >'
  what():  open: Address family not supported by protocol
Aborted
The problem commit is 6e933988d858e7ccf5832db72ac0afcd63bc1f9f
Could you test if this PR fixed your issue? https://github.com/freeorion/freeorion/pull/2640

Re: Problems with pull request #2536

Posted: Thu Nov 14, 2019 7:21 pm
by o01eg
I've updated my PR. Could you test if it solved your issue?

Re: Problems with pull request #2536

Posted: Sun Nov 17, 2019 11:44 am
by Vezzra
@spikethehobbit, your input for o01eg's fix would be much appreciated... the issue is release-blocking after all, and therefore somewhat urgent...

Re: Problems with pull request #2536

Posted: Sat Dec 07, 2019 10:20 pm
by spikethehobbit
I apologize for the delay. Just tested it and it works correctly for both single and multiplayer games. Thank you.

Re: Problems with pull request #2536

Posted: Sun Dec 08, 2019 7:32 pm
by Vezzra
Perfect :D