Species InterDesign Academy Research bugfix

Programmers discuss here anything related to FreeOrion programming. Primarily for the developers to discuss.

Moderators: Committer, Committer

Post Reply
Message
Author
Telos
Space Floater
Posts: 45
Joined: Thu May 09, 2013 4:46 am

Species InterDesign Academy Research bugfix

#1 Post by Telos » Tue Jan 15, 2019 10:52 am

The Species InterDesign Academy does not provide a noticeable research boost. I think the problem is that in line 94, its effect on research-focused planets is this:

Code: Select all

94            SetResearch value = Value + 5
This has the effect of quickly ramping up the research meter to its maximum value (like force-energy structures on steroids) but does not increase the planet's maximum or "target" value, so doesn't actually help exceed that cap. I would suggest that the effect should probably use SetTargetResearch rather than SetResearch:

Code: Select all

94            SetTargetResearch value = Value + 5

User avatar
Oberlus
Cosmic Dragon
Posts: 1489
Joined: Mon Apr 10, 2017 4:25 pm

Re: Species InterDesign Academy Research bugfix

#2 Post by Oberlus » Tue Jan 15, 2019 12:11 pm

Good catch!
If you use git/github, you could send a PR to fix it (anyway, I guess Ophiuchus will do it eventually).
Pleasepleaseplease, join fifth multiplayer slow game!

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12453
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Species InterDesign Academy Research bugfix

#3 Post by Geoff the Medio » Tue Jan 15, 2019 1:00 pm

Oberlus wrote:
Tue Jan 15, 2019 12:11 pm
If you use git/github, you could send a PR to fix it
Or make an issue that identifies the problem.

Post Reply