When adding some extra effects trace logging to try tracking down this issue with wrong troop regen, I noticed a much more minor issue, but being frustrated with the troops issue, and wanting to get at least something more productive accomplished, I am posting on this more minor issue.
What caught my eye was some interesting looking logs entries, like the following (which is slightly redacted and with some additional newlines added for clarity)
The fact that all these buildings are being listed as targets for a condition described as "that is a Large planet" caught my eye. They do properly match the current script, as a very minor adjustment I think we should edit the planet-size description to me more clear, as our Effects Tutorial is, to be "that is, or is contained by, a X planet"[trace] effects : Universe.cpp:1103 : StoreTargetsAndCausesOfEffectsGroups: effects_group: LARGE_PLANET_LABEL
....specific_cause: SHP_GAL_EXPLO sources: Invincible Nipiruk I (9156) )
[trace] effects : Universe.cpp:1078 : Generated new target set, for Condition: that belongs to source's owner empire and that is a Large planet
....targets: (Scanning Facility (31366) Automated History Analyser (23020) Imperial Palace (9380) Cultural Archives (9366) Orbital Drydock (9352) Basic Shipyard (9338) Invincible Nipiruk I (9156) )
I also pondered the somewhat more significant issue of whether we should adjust the scripts for such things, in this case the pertinent part is
Code: Select all
scope = And [
OwnedBy empire = Source.Owner
Planet size = Large
]
Code: Select all
scope = And [
OwnedBy empire = Source.Owner
Planet
Planet size = Large
]
As a minor point also, I noted in SHP_GAL_EXPLO that most of the EffecsGroups had
Code: Select all
activation = Planet