Colony building set to take 6 turns but will actually finish in 5

Describe your experience with the latest version of FreeOrion to help us improve it.

Moderator: Oberlus

Forum rules
Always mention the exact version of FreeOrion you are testing.

When reporting an issue regarding the AI, if possible provide the relevant AI log file and a save game file that demonstrates the issue.
Post Reply
Message
Author
ThinkSome
Psionic Snowflake
Posts: 460
Joined: Sun Mar 29, 2020 11:13 pm

Colony building set to take 6 turns but will actually finish in 5

#1 Post by ThinkSome »

FO e978c5e +

Code: Select all

diff --git a/default/scripting/common/upkeep.macros b/default/scripting/common/upkeep.macros
index a98fd12dc..36505f220 100644
--- a/default/scripting/common/upkeep.macros
+++ b/default/scripting/common/upkeep.macros
@@ -1,18 +1,8 @@
 COLONY_UPKEEP_MULTIPLICATOR
-'''(1 + 0.06 * SpeciesColoniesOwned empire = Source.Owner)'''
+'''1'''
 
 FLEET_UPKEEP_MULTIPLICATOR
-'''(1 +
-    (1 - (GameRule name = "RULE_SHIP_PART_BASED_UPKEEP")) * (
-        (0.01 * ShipDesignsOwned empire = Source.Owner) +
-        (0.01 * ShipDesignsInProduction empire = Source.Owner)) +
-    (GameRule name = "RULE_SHIP_PART_BASED_UPKEEP") * (
-        (0.002 * ShipPartsOwned empire = Source.Owner class = ShortRange) +
-        (0.002 * ShipPartsOwned empire = Source.Owner class = FighterHangar) +
-        (0.002 * ShipPartsOwned empire = Source.Owner class = Armour) +
-        (0.002 * ShipPartsOwned empire = Source.Owner class = Troops) +
-        (0.002 * ShipDesignsOwned empire = Source.Owner) +
-        (0.01 * ShipDesignsInProduction empire = Source.Owner)))'''
+'''1'''
 
 SHIP_HULL_COST_MULTIPLIER
 '''(GameRule name = "RULE_SHIP_HULL_COST_FACTOR")'''
Attached is a save game + picture. The bug is at Gaea beta I.
Attachments
colony.zip
(549.46 KiB) Downloaded 77 times

User avatar
swaq
Space Dragon
Posts: 384
Joined: Tue Aug 20, 2019 1:56 pm

Re: Colony building set to take 6 turns but will actually finish in 5

#2 Post by swaq »

Do you have a save from before you started building the colony?

Interestingly the percentage complete goes up in 20% chunks (consistent with 5 turns) even though it is displayed as 6 turns.

ThinkSome
Psionic Snowflake
Posts: 460
Joined: Sun Mar 29, 2020 11:13 pm

Re: Colony building set to take 6 turns but will actually finish in 5

#3 Post by ThinkSome »

Last 5 saves.
Attachments
colony.zip
(1.39 MiB) Downloaded 71 times

User avatar
Vezzra
Release Manager, Design
Posts: 6095
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: Colony building set to take 6 turns but will actually finish in 5

#4 Post by Vezzra »

If not already addressed/resolved, please open github issue.

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13587
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Colony building set to take 6 turns but will actually finish in 5

#5 Post by Geoff the Medio »


User avatar
LienRag
Cosmic Dragon
Posts: 2146
Joined: Fri May 17, 2019 5:03 pm

Re: Colony building set to take 6 turns but will actually finish in 5

#6 Post by LienRag »

In one of my games (4.8 stable) I had an outpost ship that was produced on turn 5 while it was scheduled for turn 6 but I incriminated the extra fraction of points that Planetary Ecology brought (on a Production-focused Capitol), without checking much more the exact calculations.

Post Reply