Freeorion forgets login details

[ThinkSome]

To reproduce:

1) Start FO
2) Connect to multiplayer server
3) Close window
4) Start FO
5) Press continue to continue a SP game
6) Close window
7) Start FO
Go to multiplayer

Result: server not remembered

[Oberlus]

Can't reproduce.

I did exactly what is described in the OP.

What I can do to make the client forget the cookie is to git checkout different branches:

1. Connect to multiplayer server with the weekly test build, play, disconnect.
2. Checkout a different branch for single player testing of random stuff (start new game or continue older one).
3. Checkout again to the weekly test build, connect to the server: it asks OTP again.

[ThinkSome]

I did not modify the build files, the only file that might have been modified is stringtables EN.

Another way to reproduce:

1) Open FO
2) Go to multiplayer screen (server is there)
3) go back and close window
4) Open FO
5) Go to multiplayer screen

Now the server is nowhere to be found.

[Oberlus]

My client is not forgetting the server address (namely freeorion-lt.dedyn.io) even when I change build files.

I did

1. Open FO, go to multiplayer, server is the "Lan game at:" list.
2. Connect to server or not, doesn't matter.
3. Go back to main menu (and exit FO or not, doesn't matter).
4. Go again into multiplayer, server is the "Lan game at:" list.
5. Exit FO and change build folder (different binaries).
6. Open FO, go to multiplayer, server is the "Lan game at:" list.
7. Exit FO and change build folder again (to previous binaries).
8. Open FO, go to multiplayer, server is the "Lan game at:" list.

Please note that I am using persistent_config.xml file and that the server is saved in that file.

A snippet:

Code: Select all

<XMLDoc>
  <network>
    <known-servers>
      <_freeorion-lt_dedyn_io>
        <address>freeorion-lt.dedyn.io</address>
      </_freeorion-lt_dedyn_io>
    </known-servers>
  </network>
  <setup>
    <multiplayer>
      <host>
        <address>freeorion-lt.dedyn.io</address>
      </host>
      <player>
        <name>Oberlus</name>
      </player>
    </multiplayer>
    <player>
      <name>Oberlus</name>
    </player>
  </setup>
</XMLDoc>

[ThinkSome]

I do not use persistent xml.

I don't believe the player should fiddle with config files for something as basic as remembering last server.

[Geoff the Medio]

https://github.com/freeorion/freeorion/issues/2945