newest 0.4.4 release [7708] compile failure on openSUSE

Questions, problems and discussion about compiling FreeOrion.

Moderator: Oberlus

Post Reply
Message
Author
raptor
Space Squid
Posts: 87
Joined: Sat Jun 02, 2012 11:29 pm

newest 0.4.4 release [7708] compile failure on openSUSE

#1 Post by raptor »

Looks like something got missed in the header refactors since [7641]:

Code: Select all

[ 1648s] [ 94%] Building CXX object client/human/CMakeFiles/freeorion.dir/__/__/UI/ObjectListWnd.cpp.o
[ 1641s] /home/abuild/rpmbuild/BUILD/FreeOrion/UI/MapWnd.cpp: In member function 'void MapWnd::DispatchFleetsExploring()':
[ 1641s] /home/abuild/rpmbuild/BUILD/FreeOrion/UI/MapWnd.cpp:5511:27: error: 'DBL_MAX' was not declared in this scope

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13587
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: newest 0.4.4 release [7708] compile failure on openSUSE

#2 Post by Geoff the Medio »

Might need to add #include <cfloat> to the top of the file...

raptor
Space Squid
Posts: 87
Joined: Sat Jun 02, 2012 11:29 pm

Re: newest 0.4.4 release [7708] compile failure on openSUSE

#3 Post by raptor »

Geoff the Medio wrote:Might need to add #include <cfloat> to the top of the file...
Yep, that did it.

If you are interested, here are some LINT warnings:

Code: Select all

[  700s] I: Program causes undefined operation
[  700s]    (likely same variable used twiceand post/pre incremented in the same expression).
[  700s]    e.g. x = x++; Split it in two operations.
[  700s] W: freeorion sequence-point /home/abuild/rpmbuild/BUILD/FreeOrion/PagedGeometry/source/ImpostorPage.cpp:141
[  700s] W: freeorion sequence-point /home/abuild/rpmbuild/BUILD/FreeOrion/PagedGeometry/source/PagedGeometry.cpp:1051
[  700s] 
[  700s] I: Program is likely to break with new gcc. Try -fno-strict-aliasing.
[  700s] W: freeorion strict-aliasing-punning /home/abuild/rpmbuild/BUILD/FreeOrion/universe/Effect.cpp:281
...
[  754s] freeorion.x86_64: W: no-manual-page-for-binary freeoriond
[  754s] freeorion.x86_64: W: no-manual-page-for-binary freeorion
[  754s] freeorion.x86_64: W: no-manual-page-for-binary freeorionca

User avatar
Vezzra
Release Manager, Design
Posts: 6095
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: newest 0.4.4 release [7708] compile failure on openSUSE

#4 Post by Vezzra »

raptor wrote:Looks like something got missed in the header refactors since [7641]
You can build r7641 without modifications, but not r7708? That's extremely odd, because both are tags of r7640 of the 0.4.4 release branch, and as such absolutely identical... :?

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13587
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: newest 0.4.4 release [7708] compile failure on openSUSE

#5 Post by Geoff the Medio »

He could be building 7708 of the trunk...

User avatar
Vezzra
Release Manager, Design
Posts: 6095
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: newest 0.4.4 release [7708] compile failure on openSUSE

#6 Post by Vezzra »

Geoff the Medio wrote:He could be building 7708 of the trunk...
Trunk has no r7708. r7708 is the revision of the RELEASE_V_0_4_4 tag. Maybe he pulled the head revision from trunk when the repo was at r7708 and only thought he got r7708, but got r7707...

raptor
Space Squid
Posts: 87
Joined: Sat Jun 02, 2012 11:29 pm

Re: newest 0.4.4 release [7708] compile failure on openSUSE

#7 Post by raptor »

Did I check out the wrong path?

Code: Select all

svn checkout -r 7708 svn://svn.code.sf.net/p/freeorion/code/trunk freeorion
I just grabbed the URL from SVN repo on the sourceforge page when following the link to the tag on the 'Compile' wiki page.

User avatar
Vezzra
Release Manager, Design
Posts: 6095
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: newest 0.4.4 release [7708] compile failure on openSUSE

#8 Post by Vezzra »

raptor wrote:Did I check out the wrong path?

Code: Select all

svn checkout -r 7708 svn://svn.code.sf.net/p/freeorion/code/trunk freeorion
I just grabbed the URL from SVN repo on the sourceforge page when following the link to the tag on the 'Compile' wiki page.
That depends on what you want. If you want the stable 0.4.4 release, then yes, you got the wrong path. In that case you need to check out the RELEASE_V_0_4_4 tag, but you checked out trunk, that's where all the new development goes on ;)

To get the 0.4.4 release:

Code: Select all

svn checkout svn://svn.code.sf.net/p/freeorion/code/tags/RELEASE_V_0_4_4 freeorion

raptor
Space Squid
Posts: 87
Joined: Sat Jun 02, 2012 11:29 pm

Re: newest 0.4.4 release [7708] compile failure on openSUSE

#9 Post by raptor »

Ah OK. Thank you. This means that my 0.4.3 and 0.4.2 releases were probably wrong, too...

I will fix it in my openSUSE packages

User avatar
Vezzra
Release Manager, Design
Posts: 6095
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: newest 0.4.4 release [7708] compile failure on openSUSE

#10 Post by Vezzra »

raptor wrote:Ah OK. Thank you. This means that my 0.4.3 and 0.4.2 releases were probably wrong, too...
No, because prior to 0.4.4 we didn't use release branches, so using the revision of trunk which had been declared the final 0.x.y release was correct.

Post Reply