MarkupBox.cpp causing failed build

Questions, problems and discussion about compiling FreeOrion.

Moderator: Oberlus

Post Reply
Message
Author
mileser
Space Squid
Posts: 57
Joined: Thu May 15, 2014 2:32 pm

MarkupBox.cpp causing failed build

#1 Post by mileser »

This line caused build to fail on most recent SVN update of 7524
control = new CUIIcon(tex_width, tex_height, texture, GG::GRAPHIC_FITGRAPHIC | GG::GRAPHIC_PROPSCALE);

I suspect it's a type where it s/b GUIICON rather than CUIIcon Edit: but, I don't know if CUIIcon is an actual object or not. whatever, this line is the one with build error.

2nd edit: says Unknown type name 'CUIIcon'
OS: OS X 10.10 Yosemite, XCode 6.01
Also: If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

User avatar
adrian_broher
Programmer
Posts: 1156
Joined: Fri Mar 01, 2013 9:52 am
Location: Germany

Re: MarkupBox.cpp causing failed build

#2 Post by adrian_broher »

Fixed in r7527. Yes CUIIcon was correct but I changed plans when doing the patch.
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz

mileser
Space Squid
Posts: 57
Joined: Thu May 15, 2014 2:32 pm

Re: MarkupBox.cpp causing failed build

#3 Post by mileser »

Ah, that can happen, can't it. :) Small things can make compilers unhappy, but easily fixed fortunately.
OS: OS X 10.10 Yosemite, XCode 6.01
Also: If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

Eloque
Space Squid
Posts: 53
Joined: Mon Jul 21, 2014 11:56 am

Re: MarkupBox.cpp causing failed build

#4 Post by Eloque »

This might be me or might be unrelated, but in version 7539 MarkupBox.cpp still breaks build for me.

It happens in line 589

Code: Select all

            m_vscroll = style->NewMultiEditVScroll(Width() - SCROLL_WIDTH, GG::Y0, SCROLL_WIDTH, Height(),
                                                          ClientUI::TextColor(), GG::CLR_ZERO);
With a "to many arguments" error, expected 3, have 6.
Code, justify, code - Pitr
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.

User avatar
adrian_broher
Programmer
Posts: 1156
Joined: Fri Mar 01, 2013 9:52 am
Location: Germany

Re: MarkupBox.cpp causing failed build

#5 Post by adrian_broher »

Eloque wrote:This might be me or might be unrelated, but in version 7539 MarkupBox.cpp still breaks build for me.
It's related to this problem and fixed in r7542. It seems like MarkupBox.cpp isn't build during the CMake compile.
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz

Post Reply