Page 1 of 1

EffectsParser

Posted: Thu Sep 20, 2012 4:10 am
by yandonman
Could I humbly request to have EffectsParser split into 4 EffectsParsers? My compiler is consistently choking on "compiler is out of heap space" on this file. Sorry to be a bother :(

Re: EffectsParser

Posted: Thu Sep 20, 2012 5:30 am
by Geoff the Medio
yandonman wrote:Could I humbly request to have EffectsParser split into 4 EffectsParsers? My compiler is consistently choking on "compiler is out of heap space" on this file.
If it's actually crashing on EffectParser.cpp, then nothing can be done; that file is only 25 lines long. If it's crashing on another file, be specific.

Re: EffectsParser

Posted: Thu Sep 20, 2012 6:03 am
by yandonman
My apologies for not being clear. It's crashing on EffectsParser2.cpp. EffectsParser1.cpp compiles fine.

All other files compile.

Re: EffectsParser

Posted: Fri Sep 21, 2012 1:36 am
by Geoff the Medio
That's at least understandable; EffectParser2 produces the biggest parser project .obj file in my build.

Re: EffectsParser

Posted: Sun Sep 23, 2012 12:41 am
by yandonman
Ok, I sucked it up and made the modifications myself. Funny how easy it was to do on a Sat morning vs after a long day at work.

Released under GPL 2.0. Any feedback, style, etc, whatnot appreciated.

(I couldn't find a way to make SVN make a patch that spanned two directories ... so the VS projects and src code mods are in separate patches. If you know a trick for this, lemme know please :) )

Re: EffectsParser

Posted: Sun Sep 23, 2012 12:54 am
by Geoff the Medio
yandonman wrote:If you know a trick for this, lemme know
Just make a patch of the enclosing directory.
yandonman wrote:Any feedback, style, etc, whatnot appreciated.
Could you be consistent in the manner of commenting out lines? I used, or tried to use, only // and not /* */ blocks to make it easier to see which lines were or weren't commented out. And don't add another layer of // to a line that already has a // at the start.