EffectsParser

Questions, problems and discussion about compiling FreeOrion.

Moderators: Oberlus, Oberlus

Post Reply
Message
Author
yandonman
Creative Contributor
Posts: 699
Joined: Thu Aug 30, 2012 12:32 am

EffectsParser

#1 Post by yandonman » Thu Sep 20, 2012 4:10 am

Could I humbly request to have EffectsParser split into 4 EffectsParsers? My compiler is consistently choking on "compiler is out of heap space" on this file. Sorry to be a bother :(
Code released under GPL 2.0. Content released under GPL 2.0 and Creative Commons Attribution-ShareAlike 3.0.

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12689
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: EffectsParser

#2 Post by Geoff the Medio » Thu Sep 20, 2012 5:30 am

yandonman wrote:Could I humbly request to have EffectsParser split into 4 EffectsParsers? My compiler is consistently choking on "compiler is out of heap space" on this file.
If it's actually crashing on EffectParser.cpp, then nothing can be done; that file is only 25 lines long. If it's crashing on another file, be specific.

yandonman
Creative Contributor
Posts: 699
Joined: Thu Aug 30, 2012 12:32 am

Re: EffectsParser

#3 Post by yandonman » Thu Sep 20, 2012 6:03 am

My apologies for not being clear. It's crashing on EffectsParser2.cpp. EffectsParser1.cpp compiles fine.

All other files compile.
Code released under GPL 2.0. Content released under GPL 2.0 and Creative Commons Attribution-ShareAlike 3.0.

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12689
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: EffectsParser

#4 Post by Geoff the Medio » Fri Sep 21, 2012 1:36 am

That's at least understandable; EffectParser2 produces the biggest parser project .obj file in my build.

yandonman
Creative Contributor
Posts: 699
Joined: Thu Aug 30, 2012 12:32 am

Re: EffectsParser

#5 Post by yandonman » Sun Sep 23, 2012 12:41 am

Ok, I sucked it up and made the modifications myself. Funny how easy it was to do on a Sat morning vs after a long day at work.

Released under GPL 2.0. Any feedback, style, etc, whatnot appreciated.

(I couldn't find a way to make SVN make a patch that spanned two directories ... so the VS projects and src code mods are in separate patches. If you know a trick for this, lemme know please :) )
Attachments

[The extension patch has been deactivated and can no longer be displayed.]

[The extension patch has been deactivated and can no longer be displayed.]

Code released under GPL 2.0. Content released under GPL 2.0 and Creative Commons Attribution-ShareAlike 3.0.

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12689
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: EffectsParser

#6 Post by Geoff the Medio » Sun Sep 23, 2012 12:54 am

yandonman wrote:If you know a trick for this, lemme know
Just make a patch of the enclosing directory.
yandonman wrote:Any feedback, style, etc, whatnot appreciated.
Could you be consistent in the manner of commenting out lines? I used, or tried to use, only // and not /* */ blocks to make it easier to see which lines were or weren't commented out. And don't add another layer of // to a line that already has a // at the start.

Post Reply