Effects?

For topics that do not fit in another sub-forum.

Moderators: Oberlus, Oberlus

Message
Author
User avatar
eleazar
Design & Graphics Lead Emeritus
Posts: 3858
Joined: Sat Sep 23, 2006 7:09 pm
Location: USA — midwest

Re: Effects?

#31 Post by eleazar » Sun Feb 19, 2012 5:28 pm

revision 4663
"adding more Dart00_tech updates to the stringtable.."

Dart00_Tech
Space Kraken
Posts: 143
Joined: Sat Jun 11, 2011 1:27 am
Location: Modesto, CA USA

Re: Effects?

#32 Post by Dart00_Tech » Sun Feb 19, 2012 5:42 pm

Ill base my next set of edits off SVN to make life easier.

User avatar
qsswin
Pupating Mass
Posts: 93
Joined: Tue Oct 18, 2011 6:48 pm
Location: UTC-5

Re: Effects?

#33 Post by qsswin » Sun Feb 19, 2012 8:02 pm

I decided to try my hand at making one of these. I
[*]fixed changes uppercase/lowercase mistakes
[*]fixed some spelling and grammar errors
[*]changed dry-dock back to drydock
While Drydock is not a word, it looks a lot better than "dry-dock." Additionally, "dry-dock" is a verb that means "to put in a dry dock." Technically the right word would be "dry dock," but I assume we previously had "drydock" because it looks better and makes more sense in a space setting.

I release my changes under GPL 2 and CC BY-SA 3.
Last edited by qsswin on Tue Mar 06, 2012 1:33 am, edited 1 time in total.

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12484
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Effects?

#34 Post by Geoff the Medio » Sun Mar 04, 2012 12:40 pm

eleazar wrote:We are standardizing on American spelling, vs British, right? There were a lot of those too. I don't care which one, personally, but i changed things to American, since that's what i remember we're doing.
You broke a few strings in that change. In particular, the stringtable key line for OPTIONS_RESOURCE_STARLANE_colorING had the COLOUR replaced with color, but the keys appear to be case-sensitive. I've only noticed that one as missing in the UI, and found it in the stringtable, but there might be others if you just search and replaced without case checking. Probably none of the stringtable keys should be changed, as some C++ code may be expecting the initial spelling, even if it's not continentally consistent. This doesn't affect the player though, as the string keys are supposed to be visible in-game.

User avatar
qsswin
Pupating Mass
Posts: 93
Joined: Tue Oct 18, 2011 6:48 pm
Location: UTC-5

Re: Effects?

#35 Post by qsswin » Tue Mar 06, 2012 1:32 am

I fixed that problem in this new patch.
Attachments

[The extension patch has been deactivated and can no longer be displayed.]


User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12484
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Effects?

#36 Post by Geoff the Medio » Tue Mar 06, 2012 2:02 am

qsswin wrote:I fixed that problem in this new patch.
The patch you posted is very oddly formatted... You appear to have produced a patch showing the difference between the 4663 stringtable file and a new file name newstringtable.txt. I can't do much with that. If you're making a new file, just post the file, or SVN add it locally before making a patch. If you're editing an existing file, which I think applies in this case, then just post a patch of changes to that file.

User avatar
eleazar
Design & Graphics Lead Emeritus
Posts: 3858
Joined: Sat Sep 23, 2006 7:09 pm
Location: USA — midwest

Re: Effects?

#37 Post by eleazar » Tue Mar 06, 2012 2:18 am

Geoff the Medio wrote:...I've only noticed that one as missing in the UI, and found it in the stringtable, but there might be others if you just search and replaced without case checking. Probably none of the stringtable keys should be changed, as some C++ code may be expecting the initial spelling, even if it's not continentally consistent. This doesn't affect the player though, as the string keys are supposed to be visible in-game.
My bad.
I intended to leave the keys alone, and didn't just run a blind search/replace. I looked at each instance before hitting "replace", though apparently i hit the wrong button at least once.

qsswin wrote:I decided to try my hand at making one of these. I
[*]fixed changes uppercase/lowercase mistakes
[*]fixed some spelling and grammar errors
[*]changed dry-dock back to dry dock
It's appreciated. At my best, i'm not a great copy editor.
qsswin wrote:While Drydock is not a word, it looks a lot better than "dry-dock." Additionally, "dry-dock" is a verb that means "to put in a dry dock." Technically the right word would be "dry dock," but I assume we previously had "drydock" because it looks better and makes more sense in a space setting.
I didn't realize "dry-dock" was just a verb, but you are right.
Probably we had "drydock" because several of the writing contributors (including myself) tend towards mushing words together. I think as this is a group project we'd better stick to standard usage except when the term is obviously part of the sci-fi setting-- stuff like: "homeworld" and "nanoreplication".

User avatar
qsswin
Pupating Mass
Posts: 93
Joined: Tue Oct 18, 2011 6:48 pm
Location: UTC-5

Re: Effects?

#38 Post by qsswin » Wed Mar 07, 2012 3:53 am

That took a while to set up :P

I installed up the SDK since I decided that if I was using SVN I might as well go the whole way.
Well, here's my new stringtable diff, fresh from "svn diff > eng_stringtable.diff":

[The extension diff has been deactivated and can no longer be displayed.]


User avatar
eleazar
Design & Graphics Lead Emeritus
Posts: 3858
Joined: Sat Sep 23, 2006 7:09 pm
Location: USA — midwest

Re: Effects?

#39 Post by eleazar » Wed Mar 07, 2012 4:30 am

Great, it is revision 4690

I changed the references to "increasing ship's health" to "repair" or words to that effect,
otherwise, i put it all in.

Post Reply