Unused hull tags

Creation, discussion, and balancing of game content such as techs, buildings, ship parts.

Moderators: Oberlus, Committer

Post Reply
Message
Author
User avatar
Oberlus
Cosmic Dragon
Posts: 5714
Joined: Mon Apr 10, 2017 4:25 pm

Unused hull tags

#1 Post by Oberlus »

I've found that there are some tags in some hulls that do not appear elsewhere (not in the FOCS files nor in any other source file).

For example, "SHINY", in the Xentronium hull, or "EXOTIC", also in Xentronium hull as well as in molecular cloud and ion storm fields.

Code: Select all

/freeorion$ grep -r EXOTIC *
default/scripting/ship_hulls/SH_XENTRONIUM.focs.txt:    tags = [ "SHINY" "EXOTIC" "GOOD_FUEL_EFFICIENCY" ]
default/scripting/fields/FLD_MOLECULAR_CLOUD.focs.txt:    tags = [ "EXOTIC" ]
default/scripting/fields/FLD_ION_STORM.focs.txt:    tags = [ "EXOTIC" ]
When I search for other strings that I know appear in C++ or python source files, that command above does find them, so I'm "quite" certain "EXOTIC" or "SHINY" are not used at all in FreeOrion.

In the case I make any PR with changes for hulls, should I (or could I) remove any unused tag?

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13587
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Unused hull tags

#2 Post by Geoff the Medio »

I think SHINY and EXOTIC were there just as test tags, and can be removed.

Post Reply