Search found 341 matches
- Wed Jul 23, 2014 5:21 pm
- Forum: Programming
- Topic: EncyclopediaDetailPanel question
- Replies: 28
- Views: 3150
Re: EncyclopediaDetailPanel question
Another thing I saw: the encyclopedia in designwnd has an "X"-close button that is not working, whereas prodwnd or researchwnd don't have that button. I searched for differences in code that can explain the presence/absence of the button but found nothing... Where is it hidden ?
- Wed Jul 23, 2014 9:09 am
- Forum: Programming
- Topic: EncyclopediaDetailPanel question
- Replies: 28
- Views: 3150
Re: EncyclopediaDetailPanel question
Hello, in the same vein, I stumbled upon something that looks strange, all the MapWnd::ShowXXX() methods start with a call to ClearProjectedFleetMovementLines(); but not ShowEmpires(). I didn't look further into it, but that made me wonder if it was just forgotten, or if there is something else I do...
- Tue Jul 22, 2014 1:40 pm
- Forum: Programming
- Topic: EncyclopediaDetailPanel question
- Replies: 28
- Views: 3150
Re: EncyclopediaDetailPanel question
Thanks, I was testing with the calls removed and found it more pleasant. Especially when the pedia toggling does not get you out of prodwnd, for example.
- Tue Jul 22, 2014 11:06 am
- Forum: Programming
- Topic: MapWnd save/restore popup visibility consistently
- Replies: 29
- Views: 3032
Re: MapWnd save/restore popup visibility consistently
I'm working on a more complete & hopefully working solution
- Sun Jul 20, 2014 11:23 am
- Forum: Programming
- Topic: EncyclopediaDetailPanel question
- Replies: 28
- Views: 3150
Re: EncyclopediaDetailPanel question
MapWnd::ShowProduction() explicitly calls m_pedia_panel->SetIndex() and ShowResearch calls m_pedia_panel->SetText("ENC_TECH", false), neither of which are necessary, I think. I'd even say they are wrong, there's no need to change the mapwnd's EncyclopediaDetailPanel in those methods, and ...
- Sat Jul 19, 2014 4:13 pm
- Forum: Programming
- Topic: EncyclopediaDetailPanel question
- Replies: 28
- Views: 3150
Re: EncyclopediaDetailPanel question
MapWnd::ShowProduction() explicitly calls m_pedia_panel->SetIndex() and ShowResearch calls m_pedia_panel->SetText("ENC_TECH", false), neither of which are necessary, I think. D'oh, this was it, I was already in these code path for the other patches, and did not see what was right in front...
- Sat Jul 19, 2014 1:32 pm
- Forum: Programming
- Topic: EncyclopediaDetailPanel question
- Replies: 28
- Views: 3150
EncyclopediaDetailPanel question
Hello, I'm trying to understand how the opening of a new EncyclopediaDetailPanel (f.e. the prodwnd or researchwnd ones) can alter what is shown in another (the mapwnd one). I'm starting to think it's coming from a chain of signals, because I can't find anything in the code that does this directly. M...
- Sat Jul 19, 2014 12:23 pm
- Forum: Programming
- Topic: MapWnd save/restore popup visibility consistently
- Replies: 29
- Views: 3032
- Sat Jul 19, 2014 12:01 pm
- Forum: Programming
- Topic: MapWnd save/restore popup visibility consistently
- Replies: 29
- Views: 3032
Re: MapWnd save/restore popup visibility consistently
Can you add license statements to posts (or as a signature) indicating you release changes under the GPL 2.0 or later? Hello, Should that statement be on every patch or post with patches ? I did a "global" declaration that my patches for FO will be GPL'd here: http://www.freeorion.org/for...
- Sat Jul 19, 2014 9:56 am
- Forum: Programming
- Topic: MapWnd save/restore popup visibility consistently
- Replies: 29
- Views: 3032
Re: MapWnd save/restore popup visibility consistently
Hello, I'd appreciate any input, comment, review or even better compile / runtime testing (especially on win32) In addition to those patches that should not change behaviour except for the consistency between the toggles, I would like to discuss additional changes: * hide messages and empires popups...
- Sat Jul 19, 2014 9:47 am
- Forum: Programming
- Topic: MapWnd save/restore popup visibility consistently
- Replies: 29
- Views: 3032
Re: MapWnd save/restore popup visibility consistently
Add this one to cover EncyclopediaDetailPanel...
- Fri Jul 18, 2014 4:22 pm
- Forum: Programming
- Topic: MapWnd save/restore popup visibility consistently
- Replies: 29
- Views: 3032
Re: MapWnd save/restore popup visibility consistently
Here is a combined diff for easier reviewing...
- Fri Jul 18, 2014 4:17 pm
- Forum: Programming
- Topic: MapWnd save/restore popup visibility consistently
- Replies: 29
- Views: 3032
- Fri Jul 18, 2014 4:16 pm
- Forum: Programming
- Topic: MapWnd save/restore popup visibility consistently
- Replies: 29
- Views: 3032
- Fri Jul 18, 2014 4:14 pm
- Forum: Programming
- Topic: MapWnd save/restore popup visibility consistently
- Replies: 29
- Views: 3032
Re: MapWnd save/restore popup visibility consistently
I think the purpose of HideAppPopups and ShowAllPopups was to accomplish what you want, but most of the "popup" windows aren't derived from MapWndPopup, so don't work with this feature. Would that be the best route for action ? I can give this a try... Hello, here is a patchset that try t...