FreeOrion

The Russian string table had some syntax errors, namely incomplete or missing multi-line string quotes. The attached patch fixes this.

In general, when trying to get a handle on changes, besides looking checking for posts here and looking at the svn history I sometimes also find it helpful to look at them in the format presented via GitHub at https://github.com/freeorion/freeorion/commits/master , but you have to keep in mind that...

I'm on 5999. SHP_LEAD_PLATE was a rebase error. But AR_LEAD_PLATE is still referenced in defaul/AI/ProductionAI.py. $ grep -rn '\<AR_LEAD_PLATE\>' * default/pl_stringtable.txt:3949:AR_LEAD_PLATE default/swe_stringtable.txt:3561:AR_LEAD_PLATE default/de_stringtable.txt:4132:AR_LEAD_PLATE default/dut_...

When searchin through the translation tables I found the ship part AR_LEAD_PLATE and the corresponding technology SHP_LEAD_PLATE. AR_LEAD_PLATE is referenced in the AI code, but there doesn't exist an actual ship part. As last time it isn't clear if this was removed intentional or if the ai code is ...

The ship part LR_ANTIMATTER_TORPEDO relies on the building BLD_SHIPYARD_CON_ENGINE. Grepping for BLD_SHIPYARD_CON_ENGINE only shows up some translation keys for spanish. Was BLD_SHIPYARD_CON_ENGINE removed intentionally? Is this a bug?

Building wurde durch Gebäude übersetzt. Unter diesem Begriff laufen verschiedene Objekte und wenn es der Imperiale Palast bezeichnet, kann ich noch einverstanden sein. Wenn es aber um einen Orbitalen Trockendock geht, so habe ich mühe mir den als Gebäude vorzustellen. Wie wäre es mit 'Anlage' oder ...

The attached patches further simplifies/removes the remaining library_all_variants patches. It also simplifies the CMake scripts by moving defintions and flags to more central places instead of setting it by target. The patch replaces/introduces the following options to GG cmake: BUILD_SHARED and BU...

The patches apply fine though No they don't with the fiven command line for patch LC_ALL=C patch -t -F 0 -N -p1 -u -V never -g0 -E -b -B .pc/GG_unbundle_libltdl.patch/ --reject-file=- < Mind the -F 0, which doesn't allow fuzzy application of patches. The problem is probably is caused by my modifica...

The attached patch simplifies UserString calls by only wrapping the translation key instead of embedding tenary operators between the brackets or composing the translation key beforehand. This allows simpler searching for translation keys in the source and in the future possibility an automated extr...

This patch removes includes of the GG/ReportParseError.h and GG/LexerFwd.h headers from libparse. GG/LexerFwd.h is just a convoluted way to include some boost headers. The defined typedef are not used in libparse. ReportParseError.h seems to include a parse error reporter, that returns the messages ...

Attached is a revised version of 10.

Also the other patches further clean up the cmake build by moving common options to a more central place and replacing library_all_variants within the fo-project with default cmake commands.

Instead of using the cmake/FindBullet.cmake script try to use the one provided by cmake.
Just delete it and if your cmake version is reasonable up to date it should pick up the one delivered with cmake.

No - an object can be removed from the ObjectMap without being removed from memory. The important thing to know is whether or not an object is still part of this Universe, so if it's replaced, one can look up an object with the same ID. I don't see the point in keeping a (logical) stray/outdated ob...

It might be more desirable after all to have a wrapper caching a pointer, which then gets notified when that pointer is no longer in the object map. You mean a weak pointer? http://en.wikipedia.org/wiki/Weak_reference http://www.boost.org/doc/libs/1_42_0/libs/smart_ptr/weak_ptr.htm Also you're talk...

There is not necessarily a single best candidate for each part class. Okay, with your explanation this sounds more sensible. About your keepers.erase(--keeper_it.base()); Problem: It seems like -- has precedence over . in this case. Also reverse iterator point to the previous element The keeper_it ...