Search found 1135 matches

by adrian_broher
Wed Mar 20, 2013 12:19 pm
Forum: Programming
Topic: Patch: Doxygen should be a cmake target in GG.
Replies: 5
Views: 365

Patch: Doxygen should be a cmake target in GG.

Hello go-devs, the current implementation of the GiGi cmake build system call doxygen at cmake configuration time. This shouldn't be the case because a cmake build needs a reconfiguration every time you want to build the documentation. The attached patch adds a new target called 'doc' that allows to...
by adrian_broher
Wed Mar 20, 2013 8:24 am
Forum: Programming
Topic: Patch: Move PagedGeometry and OpenSteer to top level
Replies: 20
Views: 617

Patch: Move PagedGeometry and OpenSteer to top level

Hello fo-devs, I would like to propose that the Ogre PagedGeometry plugin code and the OpenSteer library should be moved out of their current location to the top level directory of the project. Also the code layout of both projects should be changed in a way that matches the upstream release code la...
by adrian_broher
Wed Mar 20, 2013 8:02 am
Forum: Programming
Topic: Patch: Use cmake FindThreads module in GG
Replies: 7
Views: 388

Patch: Use cmake FindThreads module in GG

Hello fo-devs,

the attached patch removes the custom written platform specific link flags selection for threads and replaces it with a cmake find_package call utilizing the FindThreads cmake module.
by adrian_broher
Thu Mar 14, 2013 10:08 am
Forum: Programming
Topic: Patch: Remove unused code.
Replies: 12
Views: 591

Re: Patch: Remove unused code.

Also, a destructor for TechTreeLayout::Edge is among the removed methods, which is probably at least being called when local Edge variables go out of scope... I find I strange that the latter isn't used... You're both right as it seems. The is an dynamic instantiation of Edge on UI/TechTreeLayout.c...
by adrian_broher
Thu Mar 14, 2013 9:55 am
Forum: Programming
Topic: Patch: Remove unused code.
Replies: 12
Views: 591

Re: Patch: Remove unused code.

[…]but for such small bits as this, I'd rather leave them in case someone else wants to modify this code and might find them useful. I will abandon the patch in that case. However the destructor should be removed as it serves no purpose. I've attached some patches under GPL 2.0 or later license. Th...
by adrian_broher
Tue Mar 12, 2013 10:49 pm
Forum: Programming
Topic: Patch: Remove unused code.
Replies: 12
Views: 591

Re: Patch: Remove unused code.

I'm not sufficiently familiar with that code to know why those unused functions are there, or whether or not we want to have them at hand without going back to get them from a previous revision. Perhaps Geoff could comment on that...? I would like to add some facts about that: GetNumberOfChildren: ...
by adrian_broher
Thu Mar 07, 2013 9:24 pm
Forum: Programming
Topic: Patch: Remove unused code.
Replies: 12
Views: 591

Re: Patch: Remove unused code.

i'm not a dev, and i'm not looking at the functions you're removing/streamlining... So you didn't even review the patch and just assume it is bad? As you said; you're not a developer, so please look up what "dead code" and "code smell" is. A lot of smart people have written something to this topic ...
by adrian_broher
Thu Mar 07, 2013 8:47 pm
Forum: Programming
Topic: Patch: Remove unused code.
Replies: 12
Views: 591

Re: Patch: Remove unused code.

Hello fo-devs, After setting up a clean freeorion build I used callcatcher [1] wrapper instead of the regular gcc/g++ as compiler. The callcatcher project is a application that was initially developed for finding dead code in the libre office code. After a run it detected serveral unused functions a...
by adrian_broher
Thu Mar 07, 2013 12:56 pm
Forum: Programming
Topic: Patch: Remove unused code.
Replies: 12
Views: 591

Patch: Remove unused code.

Hello fo-devs, grepping through the code revealed that the classes store_category_impl and store_tech_impl defined in universe/Tech.cpp are not instanced anywhere. The attached patch removes these classes from the code base. The patch is released under the GPL 2.0 (or later) license. Regards Marcel ...
by adrian_broher
Fri Mar 01, 2013 10:07 am
Forum: Programming
Topic: Patch: Prefer GIGIDIR over pkgconfig
Replies: 5
Views: 406

Patch: Prefer GIGIDIR over pkgconfig

Hello fo-devs, the current implementation of the FindGiGi.cmake expects that either pkg-config isn't installed or the GiGi library has installed the corresponding .pc configuration file in a pkg-config search path. Attached is a patch, that prefers always the CMake GIGIDIR variable if set. This allo...