FreeOrion

I clone master, copy the stuff from bin into the repository directory, switch to the godot-build branch, rebase on master, pick the fixes to cmake and the includes discussed earlier, generate the build files (first cmake call), then try to run the second cmake call to build, and get a long that star...

Godot client is freeorongodot.dll. You need to download Godot for windows https://godotengine.org/download/windows, place it with default, .exe, and .dll files, and then start it. I need more specific instructions. I put the Godot_v3.2.3-stable_win64.exe in the Release directory and started it, but...

Something missing in util/Enum.h but not sure. Could you try to add includes here for <string> ? Yes, and now it builds. Not sure why... util/Enum.h | 1 + util/OrderSet.h | 1 + 2 files changed, 2 insertions(+) diff --git a/util/Enum.h b/util/Enum.h index 8fceb294c..8a4b94bb0 100644 --- a/util/Enum....

I get c:\users\g_top\desktop\fosdk11_godot\freeorion\universe\UnlockableItem.h(10): error C2679: binary '>>': no operator found which takes a right-hand operand of type 'std::string' (or there is no acceptable conversion) [C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrion\build\freeorioncommon.vcxproj]...

Also apply some CMake fixes from: https://github.com/freeorion/freeorion/pull/3409 Yes, I did that: CMakeLists.txt | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 9e22f6a07..84e55ff8b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.t...

What is "the project root"? The SDK root directory? That contains bin directly, so I don't see how ..\bin\* will work. I mean FreeOrion project which is suppose to be place in SDK dir. So if starting from a fresh SDK unpack, I first need to manually check out FreeOrion master, then cd into that dir...

N, it should work from the project root. What is "the project root"? The SDK root directory? That contains bin directly, so I don't see how ..\bin\* will work. Regardless, if I'm in the SDK room, and pushd build then call the cmake command, it fails because there's no CMakeLists.txt in the SDK root...

CMake project needs some preparation: cp ..\bin\* . mkdir build pushd build cmake -G "Visual Studio 16 2019" -T v141 -A Win32 -DBUILD_TESTING=On .. Where am I supposed to run those commands? In ./cmake ? It still doesn't work from there, even with a freshly unpacked SDK.

o01eg wrote: ↑Fri Apr 16, 2021 8:01 am pushd is to go into build directory

So the same as cd build?

bin should be appeared after unpacking SDK.

There is a bin directory in the SDK itself, but it's gone after running bootstrap. Then all the .dll and similar files are moved into the source directory...

Where is the "bin" directory supposed to be?

What is the "pushd" for?

I suppose CMake should be able build it for windows. It only requires that fix https://github.com/freeorion/freeorion/pull/3263/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a Just take the existing SDK, patch CMakeLists.txt in the root FreeOrion directory, and generate ...

o01eg wrote: ↑Thu Apr 15, 2021 9:02 pmCould we start accepting Godot client to the master branch?

I'd like to see or even try it out before doing that... Is a Windows build possible? If not, can you post some screenshots or a video?

A pull request is "request" to merge a branch into master. If you have two separate commits you want to make separate pull requests for, you need two separate branches, both based off master, each with one of those commits in it and not the other.

Anvil wrote: ↑Sat Apr 10, 2021 6:03 pmAnd I thought all I need is git...

You don't need any GitHub specific software on your own machine to fetch / pull / rebase / push etc. You do obviously need an account on github, but the pushing and such just uses git as far as I'm aware.

TravisCI and GitHub Actions already do something quite similar, I think?