FreeOrion

Forums for the FreeOrion project
It is currently Thu Jun 20, 2013 10:16 am

All times are UTC




Post new topic Reply to topic  [ 39 posts ]  Go to page Previous  1, 2, 3
Author Message
 Post subject: Re: Effects?
PostPosted: Sun Feb 19, 2012 5:28 pm 
Offline
Design & Graphics Lead
User avatar

Joined: Sat Sep 23, 2006 7:09 pm
Posts: 3707
Location: USA — midwest
revision 4663
"adding more Dart00_tech updates to the stringtable.."

_________________
—• Read this First before posting Game Design Ideas!
—• Design Philosophy

—•— My Ideas, Organized —•— Get an Avatar —•— Acronyms —•—


Top
 Profile  
 
 Post subject: Re: Effects?
PostPosted: Sun Feb 19, 2012 5:42 pm 
Offline
Space Kraken

Joined: Sat Jun 11, 2011 1:27 am
Posts: 143
Location: Modesto, CA USA
Ill base my next set of edits off SVN to make life easier.


Top
 Profile  
 
 Post subject: Re: Effects?
PostPosted: Sun Feb 19, 2012 8:02 pm 
Offline
Space Squid
User avatar

Joined: Tue Oct 18, 2011 6:48 pm
Posts: 93
Location: UTC-5
I decided to try my hand at making one of these. I
[*]fixed changes uppercase/lowercase mistakes
[*]fixed some spelling and grammar errors
[*]changed dry-dock back to drydock
While Drydock is not a word, it looks a lot better than "dry-dock." Additionally, "dry-dock" is a verb that means "to put in a dry dock." Technically the right word would be "dry dock," but I assume we previously had "drydock" because it looks better and makes more sense in a space setting.

I release my changes under GPL 2 and CC BY-SA 3.


Last edited by qsswin on Tue Mar 06, 2012 1:33 am, edited 1 time in total.

Top
 Profile  
 
 Post subject: Re: Effects?
PostPosted: Sun Mar 04, 2012 12:40 pm 
Offline
Programming, Design, and De Facto Lead
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 8062
Location: Vancouver, BC
eleazar wrote:
We are standardizing on American spelling, vs British, right? There were a lot of those too. I don't care which one, personally, but i changed things to American, since that's what i remember we're doing.
You broke a few strings in that change. In particular, the stringtable key line for OPTIONS_RESOURCE_STARLANE_colorING had the COLOUR replaced with color, but the keys appear to be case-sensitive. I've only noticed that one as missing in the UI, and found it in the stringtable, but there might be others if you just search and replaced without case checking. Probably none of the stringtable keys should be changed, as some C++ code may be expecting the initial spelling, even if it's not continentally consistent. This doesn't affect the player though, as the string keys are supposed to be visible in-game.


Top
 Profile  
 
 Post subject: Re: Effects?
PostPosted: Tue Mar 06, 2012 1:32 am 
Offline
Space Squid
User avatar

Joined: Tue Oct 18, 2011 6:48 pm
Posts: 93
Location: UTC-5
I fixed that problem in this new patch.


Attachments:
File comment: Updated version of the one in my last post.
stringtable2.patch [29.79 KiB]
Downloaded 6 times
Top
 Profile  
 
 Post subject: Re: Effects?
PostPosted: Tue Mar 06, 2012 2:02 am 
Offline
Programming, Design, and De Facto Lead
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 8062
Location: Vancouver, BC
qsswin wrote:
I fixed that problem in this new patch.

The patch you posted is very oddly formatted... You appear to have produced a patch showing the difference between the 4663 stringtable file and a new file name newstringtable.txt. I can't do much with that. If you're making a new file, just post the file, or SVN add it locally before making a patch. If you're editing an existing file, which I think applies in this case, then just post a patch of changes to that file.


Top
 Profile  
 
 Post subject: Re: Effects?
PostPosted: Tue Mar 06, 2012 2:18 am 
Offline
Design & Graphics Lead
User avatar

Joined: Sat Sep 23, 2006 7:09 pm
Posts: 3707
Location: USA — midwest
Geoff the Medio wrote:
...I've only noticed that one as missing in the UI, and found it in the stringtable, but there might be others if you just search and replaced without case checking. Probably none of the stringtable keys should be changed, as some C++ code may be expecting the initial spelling, even if it's not continentally consistent. This doesn't affect the player though, as the string keys are supposed to be visible in-game.

My bad.
I intended to leave the keys alone, and didn't just run a blind search/replace. I looked at each instance before hitting "replace", though apparently i hit the wrong button at least once.


qsswin wrote:
I decided to try my hand at making one of these. I
[*]fixed changes uppercase/lowercase mistakes
[*]fixed some spelling and grammar errors
[*]changed dry-dock back to dry dock

It's appreciated. At my best, i'm not a great copy editor.

qsswin wrote:
While Drydock is not a word, it looks a lot better than "dry-dock." Additionally, "dry-dock" is a verb that means "to put in a dry dock." Technically the right word would be "dry dock," but I assume we previously had "drydock" because it looks better and makes more sense in a space setting.

I didn't realize "dry-dock" was just a verb, but you are right.
Probably we had "drydock" because several of the writing contributors (including myself) tend towards mushing words together. I think as this is a group project we'd better stick to standard usage except when the term is obviously part of the sci-fi setting-- stuff like: "homeworld" and "nanoreplication".

_________________
—• Read this First before posting Game Design Ideas!
—• Design Philosophy

—•— My Ideas, Organized —•— Get an Avatar —•— Acronyms —•—


Top
 Profile  
 
 Post subject: Re: Effects?
PostPosted: Wed Mar 07, 2012 3:53 am 
Offline
Space Squid
User avatar

Joined: Tue Oct 18, 2011 6:48 pm
Posts: 93
Location: UTC-5
That took a while to set up :P

I installed up the SDK since I decided that if I was using SVN I might as well go the whole way.
Well, here's my new stringtable diff, fresh from "svn diff > eng_stringtable.diff":
Attachment:
eng_stringtable.diff [27.7 KiB]
Downloaded 8 times


Top
 Profile  
 
 Post subject: Re: Effects?
PostPosted: Wed Mar 07, 2012 4:30 am 
Offline
Design & Graphics Lead
User avatar

Joined: Sat Sep 23, 2006 7:09 pm
Posts: 3707
Location: USA — midwest
Great, it is revision 4690

I changed the references to "increasing ship's health" to "repair" or words to that effect,
otherwise, i put it all in.

_________________
—• Read this First before posting Game Design Ideas!
—• Design Philosophy

—•— My Ideas, Organized —•— Get an Avatar —•— Acronyms —•—


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 39 posts ]  Go to page Previous  1, 2, 3

All times are UTC


Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group