FreeOrion

Forums for the FreeOrion project
It is currently Sun May 19, 2013 2:51 pm

All times are UTC




Post new topic Reply to topic  [ 4 posts ] 
Author Message
 Post subject: Naming Asteroids
PostPosted: Tue Feb 07, 2012 3:39 am 
Offline
Space Krill

Joined: Mon Feb 06, 2012 8:26 am
Posts: 5
Location: Baton Rouge, LA
Quote:
6) Lots of places labeled "Asteroid belt" in various systems. Perhaps a different naming scheme involving the system name, e.g. "Orion Asteroids"


I made two patches which do variations on this. Here is a simple one, which changes the naming scheme to "Orion Asteroid Belt":

Attachment:
File comment: Simple patch.

Diff to SVN4626, file is in trunk/FreeOrion/universe/

system_astroid_belt.diff [592 Bytes]
Downloaded 13 times


And here is a more complex one which identifies which numbers asteroid belts on systems with multiple asteroid belts.

Attachment:
File comment: More complicated patch.

Diff to SVN4626, file is in trunk/FreeOrion/universe/

system_astroid_belt_complex.diff [1.71 KiB]
Downloaded 12 times


Top
 Profile  
 
 Post subject: Re: Naming Asteroids
PostPosted: Mon Mar 12, 2012 12:56 pm 
Offline
Design & Graphics Lead
User avatar

Joined: Sat Sep 23, 2006 7:09 pm
Posts: 3693
Location: USA — midwest
This seems like a good idea. Were there objections to using one of these patches?

_________________
—• Read this First before posting Game Design Ideas!
—• Design Philosophy

—•— My Ideas, Organized —•— Get an Avatar —•— Acronyms —•—


Top
 Profile  
 
 Post subject: Re: Naming Asteroids
PostPosted: Fri Apr 06, 2012 3:28 pm 
Offline
Space Floater

Joined: Thu Jun 24, 2010 9:45 pm
Posts: 19
Location: France
Is there a reason this patch has not been added?


Top
 Profile  
 
 Post subject: Re: Naming Asteroids
PostPosted: Fri Apr 06, 2012 7:21 pm 
Offline
Programming, Design, and De Facto Lead
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 7887
Location: Vancouver, BC
The change seems unnecessary to me, and the complicated one lacks a statement of releasing it under the GPL as needed for use. There are also some minor code problems (tabs vs. spaces). I also don't like that any sort multi-part name that describes something and also adds a unique identifier is not really translatable. With "SystemName Asteroids", there's a (relatively) translation-independent SystemName, but then Asteroids which should be translated. That means there'll be no way to have a client-side translation of "Asteroids" that different from what language stringtable the server is using.

I'll implement my own version of naming asteroids after their system, though.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 4 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group