FreeOrion

Forums for the FreeOrion project
It is currently Tue May 21, 2013 2:28 am

All times are UTC




Post new topic Reply to topic  [ 13 posts ] 
Author Message
 Post subject: [PATCH] Ship Built SitRep
PostPosted: Fri Jan 13, 2012 3:59 am 
Offline
Space Floater

Joined: Thu Oct 20, 2011 10:14 pm
Posts: 27
The situation report for a ship being built now says the ships design also.

The sitrep for creating a ship would now read for example:
"The ship Woodpecker has been produced at Grotto. The Woodpecker is a Scout."


Attachments:
sitrep.patch [2.41 KiB]
Downloaded 11 times
Top
 Profile  
 
 Post subject: Re: [PATCH] Ship Built SitRep
PostPosted: Fri Jan 13, 2012 4:22 am 
Offline
Design & Graphics Lead
User avatar

Joined: Sat Sep 23, 2006 7:09 pm
Posts: 3693
Location: USA — midwest
Good idea!

I'd rephrase it:
"A Scout has been produced at Grotto. It is named Woodpecker."

To put the important info first.

_________________
—• Read this First before posting Game Design Ideas!
—• Design Philosophy

—•— My Ideas, Organized —•— Get an Avatar —•— Acronyms —•—


Top
 Profile  
 
 Post subject: Re: [PATCH] Ship Built SitRep
PostPosted: Fri Jan 13, 2012 4:32 am 
Offline
Space Floater

Joined: Thu Oct 20, 2011 10:14 pm
Posts: 27
eleazar wrote:
Good idea!

I'd rephrase it:
"A Scout has been produced at Grotto. It is named Woodpecker."

To put the important info first.


Ah good point thanks that does sound much better.


Attachments:
sitrep.patch [2.4 KiB]
Downloaded 7 times
Top
 Profile  
 
 Post subject: Re: [PATCH] Ship Built SitRep
PostPosted: Sat Jan 14, 2012 5:53 pm 
Offline
Designer and Programmer
User avatar

Joined: Tue Aug 14, 2007 6:33 pm
Posts: 1771
Location: Orion
It used to say something along the lines of "The ship Woodpecker has been produced at Grotto" right?

Why not just replace the word "ship" with the ship class?

"The Scout 'Woodpecker' has been produced at Grotto" or "The Leviathan 'War Hammer' has been produced at Orion" (using quotation marks to more clearly delineate the ship type and the ship name).

_________________
Warning: Antarans in dimensional portal are closer than they appear.


Top
 Profile  
 
 Post subject: Re: [PATCH] Ship Built SitRep
PostPosted: Sat Jan 14, 2012 9:02 pm 
Offline
Design & Graphics Lead
User avatar

Joined: Sat Sep 23, 2006 7:09 pm
Posts: 3693
Location: USA — midwest
Bigjoe5 wrote:
"The Scout 'Woodpecker' has been produced at Grotto" or "The Leviathan 'War Hammer' has been produced at Orion" (using quotation marks to more clearly delineate the ship type and the ship name).

Even better.

_________________
—• Read this First before posting Game Design Ideas!
—• Design Philosophy

—•— My Ideas, Organized —•— Get an Avatar —•— Acronyms —•—


Top
 Profile  
 
 Post subject: Re: [PATCH] Ship Built SitRep
PostPosted: Sat Jan 14, 2012 9:10 pm 
Offline
Programming, Design, and De Facto Lead
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 7888
Location: Vancouver, BC
eng_stringtable.txt wrote:
SITREP_SHIP_BUILT
A %shipdesign% has been produced at %system%. It is named %ship%.
Should be just a stringtable change, so feel free to experiment / commit.


Top
 Profile  
 
 Post subject: Re: [PATCH] Ship Built SitRep
PostPosted: Sat Jan 14, 2012 10:51 pm 
Offline
Design & Graphics Lead
User avatar

Joined: Sat Sep 23, 2006 7:09 pm
Posts: 3693
Location: USA — midwest
Ok, it's now:
A %shipdesign%,'%ship%' has been produced at %system%.

_________________
—• Read this First before posting Game Design Ideas!
—• Design Philosophy

—•— My Ideas, Organized —•— Get an Avatar —•— Acronyms —•—


Top
 Profile  
 
 Post subject: Re: [PATCH] Ship Built SitRep
PostPosted: Thu Jan 19, 2012 4:53 pm 
Offline
Programmer and Packager
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 765
Location: Sol III
eleazar wrote:
Ok, it's now:
A %shipdesign%,'%ship%' has been produced at %system%.

Hm, besides a missing space after the comma, I see a potential grammatical problem with the use of an indefinite article here: if someone happens to create a design and give it a name starting with a vowel, let's say, for example, "Ark", we will get: "A Ark, 'Trafalgar' has been produced at Grotto." Now I'm not a native speaker, but shouldn't that be "An Ark..."?

So my suggestions would be, to make things simple: Drop the indefinite article and the comma, so it will read: "%shipdesign% '%ship%' has been produced at %system%." My previous example would result in: "Ark 'Trafalgar' has been produced at Grotto".


Top
 Profile  
 
 Post subject: Re: [PATCH] Ship Built SitRep
PostPosted: Thu Jan 19, 2012 5:23 pm 
Offline
Designer and Programmer
User avatar

Joined: Tue Aug 14, 2007 6:33 pm
Posts: 1771
Location: Orion
I don't see a problem with simply using the definite article, since there is only one ship with the particular name. So even though the 'Woodpecker' is a Scout, it's still the Scout 'Woodpecker'.

_________________
Warning: Antarans in dimensional portal are closer than they appear.


Top
 Profile  
 
 Post subject: Re: [PATCH] Ship Built SitRep
PostPosted: Fri Jan 20, 2012 11:50 pm 
Offline
Design & Graphics Lead
User avatar

Joined: Sat Sep 23, 2006 7:09 pm
Posts: 3693
Location: USA — midwest
Can we get "SITREP_SHIP_DESTROYED_AT_SYSTEM" to also understand the ship design and owner, so it can read:
"The Humanix Imperium Mark II, Seeker was destroyed at Procyon"
instead of
"The ship Seeker was destroyed at Procyon"

_________________
—• Read this First before posting Game Design Ideas!
—• Design Philosophy

—•— My Ideas, Organized —•— Get an Avatar —•— Acronyms —•—


Top
 Profile  
 
 Post subject: Re: [PATCH] Ship Built SitRep
PostPosted: Sat Jan 21, 2012 12:44 am 
Offline
Programming, Design, and De Facto Lead
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 7888
Location: Vancouver, BC
eleazar wrote:
Can we get "SITREP_SHIP_DESTROYED_AT_SYSTEM" to also understand the ship design and owner, so it can read:
"The Humanix Imperium Mark II, Seeker was destroyed at Procyon"
instead of
"The ship Seeker was destroyed at Procyon"

There might be minor issues with non-player owned ships... and I don't recall whether this string is used for non-player-owned monsters.


Top
 Profile  
 
 Post subject: Re: [PATCH] Ship Built SitRep
PostPosted: Sat Jan 21, 2012 4:32 am 
Offline
Programming, Design, and De Facto Lead
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 7888
Location: Vancouver, BC
Geoff the Medio wrote:
There might be minor issues with non-player owned ships... and I don't recall whether this string is used for non-player-owned monsters.
There were some issues as expected, but:
* I made extra sitrep messages for unowned ships, fleets, planets, and buildings being destroyed.
* Monsters that are unowned use the unowned ship sitrep. This works for that, but it's a bit awkward since monster ships usually have the same name as their ship design, so you end up with "The Dyson Tree Dyson Tree was destroyed at Bell."


Top
 Profile  
 
 Post subject: Re: [PATCH] Ship Built SitRep
PostPosted: Sat Jan 21, 2012 2:07 pm 
Offline
Space Dragon
User avatar

Joined: Sun Sep 25, 2011 2:51 pm
Posts: 264
Geoff the Medio wrote:
* Monsters that are unowned use the unowned ship sitrep. This works for that, but it's a bit awkward since monster ships usually have the same name as their ship design, so you end up with "The Dyson Tree Dyson Tree was destroyed at Bell."

Maybe some name generator could be provided for monsters?

_________________
[...] for Man has earned his right to hold this planet against all comers, by virtue of occasionally producing someone totally batshit insane. - xkcd


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 13 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group