Geoff the Medio wrote:
...I'm not sure if there's any case where fleet plans are made not by parsing, but it'd probably be OK to change the default value of that parameter for FleetPlan to true.
As far as I can tell fleet plans currently are only used to set up the starting fleets, and because of that my first try to solve the issue has been exactly that, changing the default value of that parameter to true. However, I wasn't comfortable with that solution because I thought this flag surely exists and defaults to false for a reason. Maybe there is no apparent use for it now, but whoever wrote that code might had some future use in mind. Not that my solution was any better, on the contrary...
To replicate the old behaviour, you might be able to pass true to the FleetPlan constructor in the parser.
Well, when in doubt go with the original plan (that already proved to be working), so I decided to replicate the old behaviour. Which I was able to do now, thanks to your hints
I'm not sure if this needs wrapping in something like val(true) as was required for the old parser...
Definitely needs wrapping - not wrapping leads to crashes, as I just found out. However, I had to use "phoenix::val" instead of just "val". Made a build and ran a quick test game, starting fleet names are back, everything seems to work fine. New patch attached.
Inspecting the name for FN_ is indeed not a good idea.
Yeah, that's not a fix, but a hack, and I didn't like it at all. Doing it this way was just asking for trouble. MUCH better now