[SOLVED] - unable to save ship designs

cami · **Joined:** Tue Sep 20, 2011 10:32 pm **Posts:** 49

I am currently unable to save any ship designs. Design window has always had its glitches (for instance using backspace in text fields rendered them immutable), but I have been able to save new designs last week. This problem occurs in vanilla r4296, so I started a bisect at r4279.

OK 4279 ... 4288 ! 4289 4290 ... 4292 ... 4296 BROKEN

broken since r4289. Seems to be an incomplete refactoring. Reporting in case it's been unnoticed.

Compiler flags used: -g -O2 -march=core2
Platform: x86_64-pc-linux-gnu

Geoff the Medio · **Posted:** Mon Sep 26, 2011 5:36 pm

On line 2371 of Empire.cpp, change the != to ==

Code:

    // design is valid, so just add the id to empire's set of ids that it knows about
    if (m_ship_designs.find(ship_design_id) == m_ship_designs.end()) {
        m_ship_designs.insert(ship_design_id);
        ShipDesignsChangedSignal();
    }

Edit: Fixed in SVN.

FreeOrion

[SOLVED] - unable to save ship designs

Who is online